[server] use owner and repo name for workspace id #7390
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change introduces optional arguments in generateWorkspaceId for the first two segments. And makes use of it in workspace factory using the repos org/group and name. fixes #4129
roboquat
added
do-not-merge/work-in-progress
do-not-merge/release-note-label-needed
team: webapp
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Associated issue: #4129 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
roboquat
added
size/M
release-note
and removed
do-not-merge/release-note-label-needed
labels
|
Closing because the branch name is too long to get deployed 🙄 |
svenefftinge
deleted the
sefftinge/please-use-a-useful-workspace-4129
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change introduces optional arguments in
generateWorkspaceIdfor the first two segments. And makes use of it in workspace factory
using the repos org/group and name.
fixes #4129
Testing
Start a workspace on GitHub and GitLab repos (try with nested groups on GitLab) and find the repo names and orgs reflected in the workspace id.
Release Notes